Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter receiver blocks before starting block #863

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

morgsmccauley
Copy link
Collaborator

As we fetch blocks for a given day, there is possibility for that day to include blocks lesser than the provided start_block_height. This PR ensures that those blocks are filtered out.

As we fetch blocks for a given day, there is possibility for that day to
include blocks lesser than the provided `start_block_height`. This PR
ensures that those blocks are filtered out.
@morgsmccauley morgsmccauley requested a review from a team as a code owner July 10, 2024 23:33
@morgsmccauley morgsmccauley self-assigned this Jul 10, 2024
Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for spotting and fixing it!

@morgsmccauley morgsmccauley merged commit e697f37 into main Jul 11, 2024
4 checks passed
@morgsmccauley morgsmccauley deleted the fix/receiver-blocks-start-block branch July 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants